-
Notifications
You must be signed in to change notification settings - Fork 794
feat(Theme): new component #4387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
@benjamincanac Any thoughts on this? I'd love to finish out the rest of this MR, just wanted to get your initial thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be easier to inject the provided ui
prop inside the ui
computed like we do for the app config? π€ https://github.com/nuxt/ui/blob/v3/src/runtime/components/Button.vue#L106
Also, I think it would be best to externalize the composable to be consistent.
Done!
My first thought was also to put it where we put app config. But the For example, applying the following in button: {
slots: {
base: 'px-20'
}
} But applying the same thing via the In other words, if I wanted to change the base padding of all buttons in an area, I would have to resort to |
π Linked issue
Resolves #4250
β Type of change
π Description
Detailed in the issue: #4250
Needing Review
This MR is still in draft mode, but I have an initial POC made. I was hoping to get feedback on the approach and the changes before applying them to all components, and writing documentation.
π Checklist