Skip to content

adding metrics semconv #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025
Merged

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Jun 13, 2025

Generate some initial metrics SemConv files. I've chosen to start small, with just http and otel groups until we need more, and thought one file per group seemed neater.

Closes: #1613

@brettmc brettmc requested a review from a team as a code owner June 13, 2025 01:48
@brettmc
Copy link
Contributor Author

brettmc commented Jun 13, 2025

When this is merged, I think we should create an issue to update our metrics generation from span and log processors to use the otel semconv attributes. They didn't exist when we first implemented.

@brettmc
Copy link
Contributor Author

brettmc commented Jun 14, 2025

Any opinions on how I've split each group into its own file?

@ChrisLightfootWild
Copy link
Contributor

Any opinions on how I've split each group into its own file?

I think I prefer it this way 👍

I'm not entirely sure on the units of measure though, although I see they are coming directly from the schemas - so maybe not much we could do with them. e.g. Unit: {connection}

@Nevay
Copy link
Contributor

Nevay commented Jun 15, 2025

Any opinions on how I've split each group into its own file?

The spec suggests a similar structure:

├── SchemaUrls.code
├── attributes
│ ├── ClientAttributes.code
│ ├── HttpAttributes.code
│ └── ...
├── metrics
│ ├── HttpMetrics.code
│ └── ...
└── events
└── ...

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.64%. Comparing base (5451d57) to head (a31ee11).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1633      +/-   ##
============================================
- Coverage     68.68%   68.64%   -0.05%     
  Complexity     2854     2854              
============================================
  Files           425      425              
  Lines          8699     8699              
============================================
- Hits           5975     5971       -4     
- Misses         2724     2728       +4     
Flag Coverage Δ
8.5 68.64% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5451d57...a31ee11. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobstrecansky bobstrecansky merged commit 33715fd into open-telemetry:main Jun 24, 2025
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[semconv] Add metrics to PHP Semantic Conventions generation
4 participants