4566 Clarifications for Composite Samplers proposal #4569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing issue open-telemetry#4566.
|
We usually don't update OTEPs, and instead clarify or refine things in the actual Spec contents. Probably worth checking this clarification exists in the Spec (too)? Wdyt @jmacd ? |
|
I would feel comfortable adjusting this in the specification directly. It seems like a very small change to write a new OTEP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #4566.
Fixes #4566
Changes
Clarifying the meaning of
IsAjustedCountReliable, providing guidance for selecting the Randomness value R for sampling decision making.