fix: reduce MCP tool name delimiter to prevent OpenAI 64-char limit errors #1371
+88
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors - Change delimiter from "__OAI_CODEX_MCP__" (17 chars) to "__" (2 chars) - Add validation and truncation logic for tool names exceeding 64 chars - Skip tools when server name alone is too long - Add hash suffix for uniqueness when truncating tool names - Add comprehensive tests for new functionality Fixes openai#1289 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
bolinfest
reviewed
Jun 25, 2025
| @@ -193,7 +198,46 @@ pub async fn list_all_tools( | |||
|
|
|||
| for tool in list_result.tools { | |||
| // TODO(mbolin): escape tool names that contain invalid characters. | |||
| let fq_name = fully_qualified_tool_name(&server_name, &tool.name); | |||
| let mut fq_name = fully_qualified_tool_name(&server_name, &tool.name); | |||
There was a problem hiding this comment.
fully_qualified_tool_name() and try_parse_fully_qualified_tool_name() must be symmetric. It is not clear that this is the case given this implementation.
Someone told me that, empirically, the model doesn't care about the names of the functions all that much and therefore, we could SHA1 the long name or something and things would still work.
Another solution that is somewhat stateful, but more readable for users, would be to get the full list of tool names and only attempt to "fully qualify them" when there is a naming collision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where MCP tool names exceed OpenAI's 64-character limit by using a shorter delimiter.
Fixes #1289