Skip to content

feat: rewrite illegal keywords as extensions #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2020
Merged

feat: rewrite illegal keywords as extensions #10

merged 1 commit into from
Apr 15, 2020

Conversation

sebas2day
Copy link

fixes: #8

Included:

  • OAS3 schema to derive its allowed keywords
  • rewrite function that rewrites as an extension whenever a keyword is not allowed
  • rewrite exception for definitions
  • tests, as well as a new "events schema" example that describes an OAS discriminator that should be left intact

@sebas2day
Copy link
Author

@philsturgeon Please review whenever you have time

@philsturgeon philsturgeon merged commit d2c23e7 into openapi-contrib:master Apr 15, 2020
@sebas2day
Copy link
Author

@philsturgeon Looks like something went wrong with the semantic release, can you give it a look?

@github-actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@philsturgeon
Copy link
Member

Sorted. Enjoy v1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate if its result is indeed a OAS3 schema
2 participants
@sebas2day @philsturgeon