Skip to content

feat: add type definitions #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021
Merged

feat: add type definitions #21

merged 1 commit into from
Mar 17, 2021

Conversation

George-Payne
Copy link

Adds typescript types.

@philsturgeon philsturgeon merged commit 631342c into openapi-contrib:master Mar 17, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@George-Payne George-Payne deleted the add-type-definitions branch March 17, 2021 12:27
@apancutt
Copy link

Shouldn't the return type be a Promise? i.e.

  declare function JsonSchemaToOpenapiSchema<T = Record<string | number, any>>(
    schema: Record<string | number, any>,
    options?: JsonSchemaToOpenapiSchema.Options
- ): T;
+ ): Promise<T>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants