Skip to content

fix: change converter return type to a promise #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2021
Merged

fix: change converter return type to a promise #23

merged 1 commit into from
Dec 29, 2021

Conversation

EmilIvanov
Copy link

@EmilIvanov EmilIvanov commented Jul 5, 2021 •
edited
Loading

Changes the converter function type declaration return type to a promise to match the function: https://github.com/openapi-contrib/json-schema-to-openapi-schema/blob/master/index.js#L27

@robertbullen robertbullen mentioned this pull request Dec 29, 2021
Closed
robertbullen
robertbullen reviewed Dec 29, 2021
View reviewed changes
Copy link

@robertbullen robertbullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert() is an async function, and therefore it returns a Promise. This proposed change is correct.

@philsturgeon philsturgeon merged commit 90c99dc into openapi-contrib:master Dec 29, 2021
@github-actions
Copy link

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbullen robertbullen robertbullen approved these changes

@philsturgeon philsturgeon philsturgeon approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilIvanov @philsturgeon @robertbullen