Skip to content

Fix Autocomplete Bugs #10000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
Merged

Conversation

LDrago27
Copy link
Collaborator

@LDrago27 LDrago27 commented Jun 26, 2025

Description

  • Devalue fields in the Autosuggestion Wizard that begin with _ (Mostly are meta fields)
  • Close the Autocomplete Suggestion Wizard when using CMD + Enter to run the query
  • Switching Datasets using the Dataset picker was still showing the fields from the previous dataset
    ( Although the React Component was being updated the provideCompletionItem Method was using the older reference for indexPattern and dataset that was causing data from previous dataset to show up. Currently Modified the method to fetch the current dataset and indexPattern from queryString manager before firing the actual autocomplete query. This ensures that we are always getting the latest updates)
  • Minor Cleanups

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix : Resolve Autocomplete bugs

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (query_explore@b7a9960). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...lore/public/components/query_panel/query_panel.tsx 0.00% 7 Missing ⚠️
..._panel/components/editor_stack/resuable_editor.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             query_explore   #10000   +/-   ##
================================================
  Coverage                 ?   60.03%           
================================================
  Files                    ?     4066           
  Lines                    ?   103701           
  Branches                 ?    16488           
================================================
  Hits                     ?    62254           
  Misses                   ?    37311           
  Partials                 ?     4136           
Flag Coverage Δ
Linux_1 28.00% <0.00%> (?)
Linux_2 41.63% <ø> (?)
Linux_3 39.31% <100.00%> (?)
Windows_1 28.01% <0.00%> (?)
Windows_2 41.61% <ø> (?)
Windows_3 39.31% <100.00%> (?)
Windows_4 29.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…query

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Copy link
Contributor

❌ Invalid Prefix

Invalid description prefix. Found "fix ". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

1 similar comment
Copy link
Contributor

❌ Invalid Prefix

Invalid description prefix. Found "fix ". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

@LDrago27 LDrago27 force-pushed the bugFixBranch branch 2 times, most recently from 109d308 to 51c7ece Compare June 27, 2025 06:47
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
@LDrago27 LDrago27 merged commit 3af01a6 into opensearch-project:query_explore Jun 27, 2025
49 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants