-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix Autocomplete Bugs #10000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Autocomplete Bugs #10000
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## query_explore #10000 +/- ##
================================================
Coverage ? 60.03%
================================================
Files ? 4066
Lines ? 103701
Branches ? 16488
================================================
Hits ? 62254
Misses ? 37311
Partials ? 4136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…query Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
❌ Invalid PrefixInvalid description prefix. Found "fix ". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
1 similar comment
❌ Invalid PrefixInvalid description prefix. Found "fix ". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
109d308
to
51c7ece
Compare
src/plugins/data/public/antlr/opensearch_ppl/code_completion.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
3af01a6
into
opensearch-project:query_explore
Description
( Although the React Component was being updated the provideCompletionItem Method was using the older reference for indexPattern and dataset that was causing data from previous dataset to show up. Currently Modified the method to fetch the current dataset and indexPattern from queryString manager before firing the actual autocomplete query. This ensures that we are always getting the latest updates)
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration