-
Notifications
You must be signed in to change notification settings - Fork 1k
[Explore] feat: Add inspection button to action bar in tabs #10001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## query_explore #10001 +/- ##
================================================
Coverage ? 60.10%
================================================
Files ? 4066
Lines ? 103617
Branches ? 16457
================================================
Hits ? 62283
Misses ? 37199
Partials ? 4135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
return { | ||
results: cacheKey ? results[cacheKey] : null, | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add unit tests for these final files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you create this hook, we could remove the other hook src/plugins/explore/public/application/utils/hooks/use_cache_keys.ts which is similar but for cacheKey only
Signed-off-by: Joey Liu <jiyili@amazon.com>
Signed-off-by: Joey Liu <jiyili@amazon.com>
Signed-off-by: Joey Liu <jiyili@amazon.com>
5805911
into
opensearch-project:query_explore
Description
legacy
folderuseTabResults
hook to replace some repeated codeIssues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration