Skip to content

[Explore] feat: Add inspection button to action bar in tabs #10001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025

Conversation

Maosaic
Copy link
Collaborator

@Maosaic Maosaic commented Jun 26, 2025

Description

  1. Move tab action bar related component out of legacy folder
  2. Add inspection button to tab action bar
  3. Introduce useTabResults hook to replace some repeated code

Issues Resolved

Screenshot

Screenshot 2025-06-26 at 4 29 50 PM Screenshot 2025-06-26 at 4 29 41 PM

Testing the changes

Changelog

  • feat: Add inspection button to action bar in tabs

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (query_explore@7aba370). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...on/utils/state_management/actions/query_actions.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             query_explore   #10001   +/-   ##
================================================
  Coverage                 ?   60.10%           
================================================
  Files                    ?     4066           
  Lines                    ?   103617           
  Branches                 ?    16457           
================================================
  Hits                     ?    62283           
  Misses                   ?    37199           
  Partials                 ?     4135           
Flag Coverage Δ
Linux_1 28.00% <ø> (?)
Linux_2 41.63% <ø> (?)
Linux_3 39.31% <ø> (?)
Windows_1 28.01% <ø> (?)
Windows_2 41.61% <ø> (?)
Windows_3 39.31% <ø> (?)
Windows_4 29.47% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

return {
results: cacheKey ? results[cacheKey] : null,
};
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add unit tests for these final files?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you create this hook, we could remove the other hook src/plugins/explore/public/application/utils/hooks/use_cache_keys.ts which is similar but for cacheKey only

Maosaic pushed a commit to Maosaic/OpenSearch-Dashboards that referenced this pull request Jun 27, 2025
angle943
angle943 previously approved these changes Jun 27, 2025
Maosaic and others added 3 commits June 27, 2025 19:18
angle943
angle943 previously approved these changes Jun 27, 2025
Signed-off-by: Joey Liu <jiyili@amazon.com>
@Maosaic Maosaic merged commit 5805911 into opensearch-project:query_explore Jun 27, 2025
12 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants