Skip to content

fix new button and add unit tests for slices #10002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

angle943
Copy link
Collaborator

  • fix new button
  • create unit tests for all slices

Signed-off-by: Justin Kim <jungkm@amazon.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (query_explore@ac67424). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ation/utils/state_management/slices/ui/ui_slice.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             query_explore   #10002   +/-   ##
================================================
  Coverage                 ?   60.16%           
================================================
  Files                    ?     4065           
  Lines                    ?   103495           
  Branches                 ?    16428           
================================================
  Hits                     ?    62271           
  Misses                   ?    37093           
  Partials                 ?     4131           
Flag Coverage Δ
Linux_1 28.00% <ø> (?)
Linux_2 41.63% <ø> (?)
Linux_3 39.31% <ø> (?)
Windows_1 28.01% <ø> (?)
Windows_2 41.61% <ø> (?)
Windows_3 39.31% <ø> (?)
Windows_4 29.50% <85.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@angle943 angle943 merged commit 7aba370 into opensearch-project:query_explore Jun 27, 2025
51 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants