-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(docs): ensure .md
files are git tracked when generating sidebar
#9891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ation Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9891 +/- ##
=======================================
Coverage 59.67% 59.67%
=======================================
Files 4030 4030
Lines 102182 102182
Branches 16113 16113
=======================================
+ Hits 60976 60980 +4
+ Misses 37194 37191 -3
+ Partials 4012 4011 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing this!!!! I keep ignoring this commit hook. So this will make life better
Just a comment tho. If we should use git status instead
return (filePath) => { | ||
if (tracked === undefined) { | ||
tracked = new Set( | ||
execSync(`git ls-files '*.md'`).toString().trim().split('\n').filter(Boolean) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this check the status? Like
execSync(`git ls-files '*.md'`).toString().trim().split('\n').filter(Boolean) | |
execSync(`git status -s '*.md'`) |
And if the file is unstaged it will have a space as the first character. In other words:
A file is staged if the first letter is not a space.
That way once we stage the markdown file and trying to commit then it will generate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script builds the sidebar using all md files, not just the modified ones in the current commit. git status -s
only returns information in the git working tree and staging area, so if I see a a.md
file on disk but it's not part of the git status
output, I won't be able to tell if it's already tracked by git and should be included in the sidebar, or if it's part of .gitignore
and should be excluded.
If you do git add new.md; git rm existing.md
, ls-files
will include new.md
but not existing.md
, so this should work properly. I think we can directly use git ls-files
results to build the sidebar instead of manual traversal, but there is some logic for path prefix and not really any benefit to refactor this
(BTW git status --porcelain
works better if you ever need it in scripts, and git diff --name-only --cached --diff-filter=A
returns the files added in staging area)
* Skip failing selenium test "should show Percentiles" (#9879) Signed-off-by: Justin Kim <jungkm@amazon.com> * [CVE-2024-4068] add package resolution for micromatch (#9846) * add package resolution for braces Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR #9846 created/updated * add package resolution for micromatch instead of braces Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR #9846 created/updated * add package resolution to @storybook/**/webpack and @storybook/**/micromatch Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR #9846 created/updated * Changeset file for PR #9846 created/updated --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * show update button on date change (#9875) * show update button on date change Signed-off-by: Ruchi Sharma <ruchi492@gmail.com> * Changeset file for PR #9875 created/updated --------- Signed-off-by: Ruchi Sharma <ruchi492@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover] Adding Back Unknown Fields (#9856) * Adding back unknown fields Signed-off-by: Sean Li <lnse@amazon.com> * Changeset file for PR #9856 created/updated * Removing unnecessary subscription, adding changes to explore plugin Signed-off-by: Sean Li <lnse@amazon.com> * Removing changes to explore plugin, will create another PR Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Implement polling for index state in Vended Dashboard progress (#9862) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> * making 3.1.0 release notes (#9892) * making 3.1 release notes Signed-off-by: Justin Kim <jungkm@amazon.com> * omit in release note Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> * ignore release_notes directory for casing check (#9897) Signed-off-by: Justin Kim <jungkm@amazon.com> * Fix CVE 2025-5889 (#9903) * Fix CVE 2025-5889 Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR #9903 created/updated --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * update 3.1 release-notes to include #9903 (#9910) Signed-off-by: Justin Kim <jungkm@amazon.com> * [UI setting] feat: keep backward compatibility for UI setting client. (#9854) * feat: keep backward compatibility for scope Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #9854 created/updated * feat: update warning messages Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update logic to keep backward compatibility Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: UT failure Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: boostrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Bugfix] Make UI setting client more robust when the setting key does not exist (#9927) * feat: add settings Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #9927 created/updated * fix: bootstrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * docs: add guidelines on testing and development (#9922) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Use `// @ts-expect-error` instead of ts_error_baseline (#9931) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add Shenoy Pratik (`@ps48`) as a maintainer (#9976) * Add Shenoy Pratik (@ps48) as a maintainer Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Changeset file for PR #9976 created/updated --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Increase timeout waiting for the exiting of an optimizer worker (#10020) * Increase timeout waiting for the exiting of an optimizer worker Notice it was showing the failed to timeout again so bumping it up like: #3193 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Changeset file for PR #10020 created/updated --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * feat(docs): ensure `.md` files are git tracked when generating sidebar (#9891) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Justin Kim <jungkm@amazon.com> * [Banner Plugin] Working static banner with no overlapping (#9989) * [Banner Plugin] Add static banner with mount point and feature flag Signed-off-by: Sid Wang <sidwang@amazon.com> * Changeset file for PR #9989 created/updated --------- Signed-off-by: Sid Wang <sidwang@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix popover not close if double click (#9993) * fix popover not close if double click Signed-off-by: Zhenxing Shen <zxshen@amazon.com> * Changeset file for PR #9993 created/updated --------- Signed-off-by: Zhenxing Shen <zxshen@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add auto-version increment workflow (#10112) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * [Navigation] Support icon in left navigation (#10021) * feat: enable icon Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: unify icon usage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #10021 created/updated * feat: update icon Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: workspace unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update icons Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add icon to overview page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize icon with tooltip Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: auto collapse left nav when route change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: lint error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: flaky from data source page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "fix: flaky from data source page" This reverts commit 3c0d0ce. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: increase coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: refactor styling Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: style Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize state Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add video to debug Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "feat: add video to debug" This reverts commit 621b688. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "Revert "feat: add video to debug"" This reverts commit 500d0f5. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: reduce flakiness of shared_links.spec.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: reduce flakiness of shared_links.spec.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "Revert "Revert "feat: add video to debug""" This reverts commit 63ef810. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Signed-off-by: Ruchi Sharma <ruchi492@gmail.com> Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Sid Wang <sidwang@amazon.com> Signed-off-by: Zhenxing Shen <zxshen@amazon.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Co-authored-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ruchi Sharma <ruchi492@gmail.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Sid Wang <sidwang@amazon.com> Co-authored-by: zxshen <zxshen@amazon.com> Co-authored-by: Sayali Gaikawad <gaiksaya@amazon.com>
* Skip failing selenium test "should show Percentiles" (opensearch-project#9879) Signed-off-by: Justin Kim <jungkm@amazon.com> * [CVE-2024-4068] add package resolution for micromatch (opensearch-project#9846) * add package resolution for braces Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR opensearch-project#9846 created/updated * add package resolution for micromatch instead of braces Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR opensearch-project#9846 created/updated * add package resolution to @storybook/**/webpack and @storybook/**/micromatch Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR opensearch-project#9846 created/updated * Changeset file for PR opensearch-project#9846 created/updated --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * show update button on date change (opensearch-project#9875) * show update button on date change Signed-off-by: Ruchi Sharma <ruchi492@gmail.com> * Changeset file for PR opensearch-project#9875 created/updated --------- Signed-off-by: Ruchi Sharma <ruchi492@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover] Adding Back Unknown Fields (opensearch-project#9856) * Adding back unknown fields Signed-off-by: Sean Li <lnse@amazon.com> * Changeset file for PR opensearch-project#9856 created/updated * Removing unnecessary subscription, adding changes to explore plugin Signed-off-by: Sean Li <lnse@amazon.com> * Removing changes to explore plugin, will create another PR Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Implement polling for index state in Vended Dashboard progress (opensearch-project#9862) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> * making 3.1.0 release notes (opensearch-project#9892) * making 3.1 release notes Signed-off-by: Justin Kim <jungkm@amazon.com> * omit in release note Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> * ignore release_notes directory for casing check (opensearch-project#9897) Signed-off-by: Justin Kim <jungkm@amazon.com> * Fix CVE 2025-5889 (opensearch-project#9903) * Fix CVE 2025-5889 Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR opensearch-project#9903 created/updated --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * update 3.1 release-notes to include opensearch-project#9903 (opensearch-project#9910) Signed-off-by: Justin Kim <jungkm@amazon.com> * [UI setting] feat: keep backward compatibility for UI setting client. (opensearch-project#9854) * feat: keep backward compatibility for scope Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#9854 created/updated * feat: update warning messages Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update logic to keep backward compatibility Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: UT failure Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: boostrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Bugfix] Make UI setting client more robust when the setting key does not exist (opensearch-project#9927) * feat: add settings Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#9927 created/updated * fix: bootstrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * docs: add guidelines on testing and development (opensearch-project#9922) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Use `// @ts-expect-error` instead of ts_error_baseline (opensearch-project#9931) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add Shenoy Pratik (`@ps48`) as a maintainer (opensearch-project#9976) * Add Shenoy Pratik (@ps48) as a maintainer Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Changeset file for PR opensearch-project#9976 created/updated --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#10020) * Increase timeout waiting for the exiting of an optimizer worker Notice it was showing the failed to timeout again so bumping it up like: opensearch-project#3193 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Changeset file for PR opensearch-project#10020 created/updated --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * feat(docs): ensure `.md` files are git tracked when generating sidebar (opensearch-project#9891) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Justin Kim <jungkm@amazon.com> * [Banner Plugin] Working static banner with no overlapping (opensearch-project#9989) * [Banner Plugin] Add static banner with mount point and feature flag Signed-off-by: Sid Wang <sidwang@amazon.com> * Changeset file for PR opensearch-project#9989 created/updated --------- Signed-off-by: Sid Wang <sidwang@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix popover not close if double click (opensearch-project#9993) * fix popover not close if double click Signed-off-by: Zhenxing Shen <zxshen@amazon.com> * Changeset file for PR opensearch-project#9993 created/updated --------- Signed-off-by: Zhenxing Shen <zxshen@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add auto-version increment workflow (opensearch-project#10112) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * [Navigation] Support icon in left navigation (opensearch-project#10021) * feat: enable icon Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: unify icon usage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#10021 created/updated * feat: update icon Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: workspace unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update icons Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add icon to overview page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize icon with tooltip Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: auto collapse left nav when route change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: lint error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: flaky from data source page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "fix: flaky from data source page" This reverts commit 3c0d0ce. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: increase coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: refactor styling Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: style Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize state Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add video to debug Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "feat: add video to debug" This reverts commit 621b688. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "Revert "feat: add video to debug"" This reverts commit 500d0f5. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: reduce flakiness of shared_links.spec.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: reduce flakiness of shared_links.spec.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "Revert "Revert "feat: add video to debug""" This reverts commit 63ef810. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Signed-off-by: Ruchi Sharma <ruchi492@gmail.com> Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Sid Wang <sidwang@amazon.com> Signed-off-by: Zhenxing Shen <zxshen@amazon.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Co-authored-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ruchi Sharma <ruchi492@gmail.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Sid Wang <sidwang@amazon.com> Co-authored-by: zxshen <zxshen@amazon.com> Co-authored-by: Sayali Gaikawad <gaiksaya@amazon.com>
* Skip failing selenium test "should show Percentiles" (opensearch-project#9879) Signed-off-by: Justin Kim <jungkm@amazon.com> * [CVE-2024-4068] add package resolution for micromatch (opensearch-project#9846) * add package resolution for braces Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR opensearch-project#9846 created/updated * add package resolution for micromatch instead of braces Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR opensearch-project#9846 created/updated * add package resolution to @storybook/**/webpack and @storybook/**/micromatch Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR opensearch-project#9846 created/updated * Changeset file for PR opensearch-project#9846 created/updated --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * show update button on date change (opensearch-project#9875) * show update button on date change Signed-off-by: Ruchi Sharma <ruchi492@gmail.com> * Changeset file for PR opensearch-project#9875 created/updated --------- Signed-off-by: Ruchi Sharma <ruchi492@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover] Adding Back Unknown Fields (opensearch-project#9856) * Adding back unknown fields Signed-off-by: Sean Li <lnse@amazon.com> * Changeset file for PR opensearch-project#9856 created/updated * Removing unnecessary subscription, adding changes to explore plugin Signed-off-by: Sean Li <lnse@amazon.com> * Removing changes to explore plugin, will create another PR Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Implement polling for index state in Vended Dashboard progress (opensearch-project#9862) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> * making 3.1.0 release notes (opensearch-project#9892) * making 3.1 release notes Signed-off-by: Justin Kim <jungkm@amazon.com> * omit in release note Signed-off-by: Justin Kim <jungkm@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> * ignore release_notes directory for casing check (opensearch-project#9897) Signed-off-by: Justin Kim <jungkm@amazon.com> * Fix CVE 2025-5889 (opensearch-project#9903) * Fix CVE 2025-5889 Signed-off-by: Justin Kim <jungkm@amazon.com> * Changeset file for PR opensearch-project#9903 created/updated --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * update 3.1 release-notes to include opensearch-project#9903 (opensearch-project#9910) Signed-off-by: Justin Kim <jungkm@amazon.com> * [UI setting] feat: keep backward compatibility for UI setting client. (opensearch-project#9854) * feat: keep backward compatibility for scope Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#9854 created/updated * feat: update warning messages Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update logic to keep backward compatibility Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: UT failure Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: boostrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Bugfix] Make UI setting client more robust when the setting key does not exist (opensearch-project#9927) * feat: add settings Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#9927 created/updated * fix: bootstrap Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * docs: add guidelines on testing and development (opensearch-project#9922) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Use `// @ts-expect-error` instead of ts_error_baseline (opensearch-project#9931) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add Shenoy Pratik (`@ps48`) as a maintainer (opensearch-project#9976) * Add Shenoy Pratik (@ps48) as a maintainer Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Changeset file for PR opensearch-project#9976 created/updated --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Increase timeout waiting for the exiting of an optimizer worker (opensearch-project#10020) * Increase timeout waiting for the exiting of an optimizer worker Notice it was showing the failed to timeout again so bumping it up like: opensearch-project#3193 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Changeset file for PR opensearch-project#10020 created/updated --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * feat(docs): ensure `.md` files are git tracked when generating sidebar (opensearch-project#9891) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Justin Kim <jungkm@amazon.com> * [Banner Plugin] Working static banner with no overlapping (opensearch-project#9989) * [Banner Plugin] Add static banner with mount point and feature flag Signed-off-by: Sid Wang <sidwang@amazon.com> * Changeset file for PR opensearch-project#9989 created/updated --------- Signed-off-by: Sid Wang <sidwang@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix popover not close if double click (opensearch-project#9993) * fix popover not close if double click Signed-off-by: Zhenxing Shen <zxshen@amazon.com> * Changeset file for PR opensearch-project#9993 created/updated --------- Signed-off-by: Zhenxing Shen <zxshen@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add auto-version increment workflow (opensearch-project#10112) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * [Navigation] Support icon in left navigation (opensearch-project#10021) * feat: enable icon Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: unify icon usage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#10021 created/updated * feat: update icon Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: workspace unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update icons Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add icon to overview page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize icon with tooltip Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: auto collapse left nav when route change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: lint error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: flaky from data source page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "fix: flaky from data source page" This reverts commit 3c0d0ce. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: increase coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: refactor styling Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: style Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize state Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add video to debug Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "feat: add video to debug" This reverts commit 621b688. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "Revert "feat: add video to debug"" This reverts commit 500d0f5. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: reduce flakiness of shared_links.spec.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: reduce flakiness of shared_links.spec.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "Revert "Revert "feat: add video to debug""" This reverts commit 63ef810. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Signed-off-by: Ruchi Sharma <ruchi492@gmail.com> Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Sid Wang <sidwang@amazon.com> Signed-off-by: Zhenxing Shen <zxshen@amazon.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Co-authored-by: Justin Kim <jungkm@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ruchi Sharma <ruchi492@gmail.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Sid Wang <sidwang@amazon.com> Co-authored-by: zxshen <zxshen@amazon.com> Co-authored-by: Sayali Gaikawad <gaiksaya@amazon.com>
Description
This PR makes the sidebar docs generation to ignore markdown files that are not git tracked. Additionally it ignores lighthouse reports in
/.lighthouseci/
directory.Issues Resolved
I might have local markdown files that are not tracked by git, it won't make sense to put those in docs/_sidebar.
The sidebar generation only includes
.md
and it does not pick up.MD
,.markdown
,.MARKDOWN
, etc. This is existing behavior.Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration