-
-
Notifications
You must be signed in to change notification settings - Fork 218
[bug] 500 internal server error for NoReverse match #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
chahatsagarmain
added a commit
to chahatsagarmain/openwisp-controller
that referenced
this issue
Nov 6, 2024
Changed regex for uuid pattern and uuid pattern check in admin.py Fixes openwisp#682 Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
chahatsagarmain
added a commit
to chahatsagarmain/openwisp-controller
that referenced
this issue
Nov 6, 2024
Changed regex for uuid pattern and uuid pattern check in admin.py Fixes openwisp#682 Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
2 tasks
Hey @pandafy , @nemesifier do we want this default message to be shown, or should we add a custom message instead? |
@praptisharma28 returning 404 is fine, the URL shouldn't be recognized in the first place, I suspect there's something wrong with some definition in the |
Unnati-Gupta24
added a commit
to Unnati-Gupta24/openwisp-controller
that referenced
this issue
Feb 12, 2025
Unnati-Gupta24
added a commit
to Unnati-Gupta24/openwisp-controller
that referenced
this issue
Feb 12, 2025
4 tasks
Unnati-Gupta24
added a commit
to Unnati-Gupta24/openwisp-controller
that referenced
this issue
Feb 17, 2025
Unnati-Gupta24
added a commit
to Unnati-Gupta24/openwisp-controller
that referenced
this issue
Feb 27, 2025
Unnati-Gupta24
added a commit
to Unnati-Gupta24/openwisp-controller
that referenced
this issue
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #681 (happens while testing that bug).
Try opening
http://localhost:8000/admin/config/device/de8fa775-1134-47b6-adc5-2da3d0626c72/history/1564/undefinedadmin/img/icon-deletelink.svg
.Expected result: 404 not found
Actual result: 500 internal server error
It looks like the URL pattern for this route is not strict enough.
The same happens with Template and VPN.
I think this is probably happening for all the url patterns, we should change the pattern and only allow letters, numbers and dashes, nothing more. The
re_path
must be kept for backward compatibility reasons (devices send the UUID without dashes and that is not recognized by Django's normalpath
functions).The text was updated successfully, but these errors were encountered: