Skip to content

[feature] Add API endpoint for indoor map coordinates #828 #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: gsoc25-map
Choose a base branch
from

Conversation

dee077
Copy link
Contributor

@dee077 dee077 commented Feb 2, 2025

Implemented API to return device coordinates for a given location ID.

Fixes #828

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #828

Description of Changes

  • Added endpoint floorplan_coordinates_list to list coordinates
  • Created a new serializer to add this below fields
fields = [
    "name", 
    "mac_address",
     "is_deactivated",
     "model",
     "os",
     "floor_name",
     "floor",
     "image",
     "location",
]
  • Added filter by floor
  • Added pagination class
  • Added test

@dee077 dee077 force-pushed the feature/828-api-indoor-map-coordinates branch 3 times, most recently from 103a39c to 611f852 Compare February 2, 2025 17:22
@coveralls
Copy link

coveralls commented Feb 2, 2025

Coverage Status

coverage: 98.888% (-0.01%) from 98.899%
when pulling 1754156 on dee077:feature/828-api-indoor-map-coordinates
into 129a42f on openwisp:master.

@dee077 dee077 closed this Feb 2, 2025
@dee077 dee077 reopened this Feb 2, 2025
@dee077 dee077 changed the title [feature] Add API endpoint for indoor map coordinates #828 [feature] Add API endpoint for indoor map coordinates Feb 2, 2025
@dee077 dee077 changed the title [feature] Add API endpoint for indoor map coordinates [feature] Add API endpoint for indoor map coordinates #828 Feb 2, 2025
@pandafy pandafy self-requested a review February 3, 2025 08:59
@nemesifier
Copy link
Member

@dee077 Isn't this part of the GSoC project idea for the indoor map?

@dee077
Copy link
Contributor Author

dee077 commented Feb 7, 2025

Yes, this aligns with the GSoC project idea for the indoor map. However, at the time, it didn’t have the gsoc-idea label, so I wasn’t aware that it would be proposed as a GSoC idea for 2025.

@dee077 dee077 changed the base branch from master to gsoc25-map May 23, 2025 14:53
@nemesifier nemesifier added the gsoc Part of a Google Summer of Code project label May 23, 2025
@dee077 dee077 force-pushed the feature/828-api-indoor-map-coordinates branch 3 times, most recently from c594ded to 2bc4e4c Compare June 11, 2025 13:32
Implemented API to return device coordinates for a given location ID.

Fixes openwisp#828
@dee077 dee077 force-pushed the feature/828-api-indoor-map-coordinates branch from d3ca54d to e1e9295 Compare June 11, 2025 13:40
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output looks very similar to GeoJSON, but it's not.
Good progress @dee077 👏

Look at where we use GeoJSON (rest_framework_gis): https://github.com/search?q=repo%3Aopenwisp%2Fopenwisp-controller%20rest_framework_gis&type=code.

Let's paginate the results and ensure the frontend can load paginated results gradually without crashing if there's many floorplan points scattered on many floors.

@github-project-automation github-project-automation bot moved this from To do (general) to In progress in OpenWISP Contributor's Board Jun 14, 2025
@dee077 dee077 force-pushed the feature/828-api-indoor-map-coordinates branch from c9ab3be to f6bf373 Compare June 16, 2025 18:15
@dee077 dee077 marked this pull request as ready for review June 17, 2025 17:14
@dee077 dee077 force-pushed the feature/828-api-indoor-map-coordinates branch from bafe7c1 to 0b15b71 Compare June 17, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc Part of a Google Summer of Code project
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

[feature] Add API endpoint that returns co-ordinates on indoor map (floorplan)
3 participants