Implement a server-side cursor to improve performance when fetching large volumes of data. #5797 #8837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay-joshi
requested changes
Jun 11, 2025
There was a problem hiding this comment.
GUI-related comments:
- Select 'Use server cursor' from the query tool. Run "select 1" query. Clicking on the Commit button gets the error message " the cursor is closed" and on Rollback "DECLARE "CURSOR:CONN:961921" CURSOR FOR ROLLBACK;" Disable those buttons in server cursor mode.
- Set "Execute with server side cursor?" To true. Select any table and click on View/Edit data. It executes the query, but again commit and rollback buttons get enabled. Now try following:
- Try to close the tab. It will not.
- Pagination shows Page no 1 of 0.
- Click on Next page or Previous page, nothing happens, and the data is lost.
Code-related comments:
- Add this new 'Use server cursor?" preference to the preferences.rst. The screenshot will be updated after Aditya's PR.
- Fix 3 small code smells in sqleditor/init.py
Fixed the issue. I have disabled the buttons right now in View/Edit data but that is debatable, we will discuss that in the review.
|
akshay-joshi
requested changes
Jun 13, 2025
| @@ -0,0 +1,117 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
What is this "-- coding: utf-8 --"
There was a problem hiding this comment.
Update the screenshot as the label changed to "Use server cursor?".
| @@ -46,7 +46,7 @@ const StyledBox = styled(Box)(({theme}) => ({ | |||
| ...theme.mixins.panelBorder.bottom, | |||
| })); | |||
|
|
|||
| function autoCommitRollback(type, api, transId, value) { | |||
| function autoCommitRollbackServerCur(type, api, transId, value) { | |||
There was a problem hiding this comment.
You’ve changed the name, which is good, but choosing a more generic name for the future would be better. Appending to a specific name could become difficult if additional menus are added later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.