Fixed an issue where pgAdmin failed to update the server connection s… #8852
Conversation
…tatus when the server was disconnected in the background and a refresh was performed on that server. pgadmin-org#8149
| // If the node is not a collection node, we need to fetch its data | ||
| // from the server and update the tree node. | ||
| try { | ||
| const url = nodeObj.generate_url(nodeItem, 'nodes', itemNodeData, true); |
There was a problem hiding this comment.
The backend call should be handled via tree_nodes.ts, and to achieve that, we may need to change the aspen tree refresh call itself. As per our current logic, only children get refreshed on refresh.
There was a problem hiding this comment.
I think then there is inconsistency at a lot of places. Similar calls are done everywhere in browser.js for tree related stuff. I referred the existing code.
There was a problem hiding this comment.
If that is the case, we should eliminate that code, too, if possible.
There was a problem hiding this comment.
I cannot do that in this PR. Removing them will require complete tree revamp and I'm facing difficulty to understand that code.
There was a problem hiding this comment.
That change doesn't require in this PR, just this PR related change would be sufficient.
There was a problem hiding this comment.
The current changes are PR related only.
…tatus when the server was disconnected in the background and a refresh was performed on that server. #8149