Skip to content

MAINT: Update comment #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025
Merged

MAINT: Update comment #3311

merged 4 commits into from
Jun 17, 2025

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jun 12, 2025

JBIG2Decode is now implemented, so comment was outdated.

JBIG2Decode is now implemented, so comment was outdated.
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (05300d5) to head (d10bda5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3311   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files          53       53           
  Lines        9029     9029           
  Branches     1674     1674           
=======================================
  Hits         8732     8732           
  Misses        177      177           
  Partials      120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JBIG2Decode is now implemented, so comment was outdated.
@pubpub-zz
Copy link
Collaborator

jbig2dec is not available in all environments, Is it?

@stefan6419846
Copy link
Collaborator

In theory, jbig2dec should be available in all environments. We just do not test it everywhere and it might be more complicated to get it running.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jun 16, 2025

For JBIG2 support, you need to install a global OS-level package as well:
[`jbig2dec`](https://github.com/ArtifexSoftware/jbig2dec) The installation procedure
depends on our operating system. For Ubuntu, just use the following for example:
```
sudo apt-get install jbig2dec
```

@pubpub-zz I didn't know this.

# Use of _data to prevent errors on non-decoded streams such as JBIG2 when its optional OS-level package has not been installed?

@stefan6419846 stefan6419846 merged commit 4fbc38d into py-pdf:main Jun 17, 2025
16 checks passed
@j-t-1 j-t-1 deleted the comment branch June 17, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants