Skip to content

ENH: Add PDF/A XMP metadata support #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 18, 2025
Merged

Conversation

Arya-A-Nair
Copy link
Contributor

@Arya-A-Nair Arya-A-Nair commented Jun 16, 2025

Closes #3313

@Arya-A-Nair Arya-A-Nair changed the title Add PDF/A XMP metadata support (issue #3313) ENH: Add PDF/A XMP metadata support (issue #3313) Jun 16, 2025
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (67d1ba1) to head (c77696b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3314   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files          53       53           
  Lines        9029     9034    +5     
  Branches     1674     1674           
=======================================
+ Hits         8732     8737    +5     
  Misses        177      177           
  Partials      120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have added some inline remarks.

Additionally, I would like to request some changes/simplifications of the tests:

  • The tests should go into test_xmp.py. While the functionality is related to PDF/A, it is just another XMP feature.

  • It should be sufficient to have exactly two tests:

    • One with sample-files/021-pdfa/crazyones-pdfa.pdf which has these values.
    • One with sample-files/020-xmp/output_with_metadata_pymupdf.pdf which does not have these values.

    The good thing about these files is that they are already cloned with a proper local development copy of the repository and do not require further downloads (and do not rely on other tests already having downloaded them).

    I suggest to have a look at the other tests utilizing SAMPLE_ROOT as well.

@stefan6419846 stefan6419846 changed the title ENH: Add PDF/A XMP metadata support (issue #3313) ENH: Add PDF/A XMP metadata support Jun 17, 2025
@stefan6419846 stefan6419846 merged commit e8e2ab6 into py-pdf:main Jun 18, 2025
16 checks passed
stefan6419846 added a commit that referenced this pull request Jun 22, 2025
## What's new

### New Features (ENH)
- Add PDF/A XMP metadata support (#3314) by @Arya-A-Nair

### Robustness (ROB)
- Deal with annotations not being lists on merge (#3321) by @stefan6419846
- Handle NullObject for cmap encoding Differences entry (#3317) by @stefan6419846

### Developer Experience (DEV)
- Update ruff to 0.12.0 (#3316) by @stefan6419846

[Full Changelog](5.6.0...5.6.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend XMP metadata support with PDF/A pdfaid namespace
2 participants