ENH: Add PDF/A XMP metadata support #3314
Conversation
Arya-A-Nair
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3314 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 53 53
Lines 9029 9034 +5
Branches 1674 1674
=======================================
+ Hits 8732 8737 +5
Misses 177 177
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Arya Nair <aryaajitnair@gmail.com>
There was a problem hiding this comment.
Thanks for the PR. I have added some inline remarks.
Additionally, I would like to request some changes/simplifications of the tests:
-
The tests should go into
test_xmp.py. While the functionality is related to PDF/A, it is just another XMP feature. -
It should be sufficient to have exactly two tests:
- One with
sample-files/021-pdfa/crazyones-pdfa.pdfwhich has these values. - One with
sample-files/020-xmp/output_with_metadata_pymupdf.pdfwhich does not have these values.
The good thing about these files is that they are already cloned with a proper local development copy of the repository and do not require further downloads (and do not rely on other tests already having downloaded them).
I suggest to have a look at the other tests utilizing
SAMPLE_ROOTas well. - One with
stefan6419846
changed the title
## What's new ### New Features (ENH) - Add PDF/A XMP metadata support (#3314) by @Arya-A-Nair ### Robustness (ROB) - Deal with annotations not being lists on merge (#3321) by @stefan6419846 - Handle NullObject for cmap encoding Differences entry (#3317) by @stefan6419846 ### Developer Experience (DEV) - Update ruff to 0.12.0 (#3316) by @stefan6419846 [Full Changelog](5.6.0...5.6.1)
## What's new ### New Features (ENH) - Add PDF/A XMP metadata support (py-pdf#3314) by @Arya-A-Nair ### Robustness (ROB) - Deal with annotations not being lists on merge (py-pdf#3321) by @stefan6419846 - Handle NullObject for cmap encoding Differences entry (py-pdf#3317) by @stefan6419846 ### Developer Experience (DEV) - Update ruff to 0.12.0 (py-pdf#3316) by @stefan6419846 [Full Changelog](py-pdf/pypdf@5.6.0...5.6.1)
Closes #3313