-
Notifications
You must be signed in to change notification settings - Fork 1.5k
ENH: Add PDF/A XMP metadata support #3314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3314 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 53 53
Lines 9029 9034 +5
Branches 1674 1674
=======================================
+ Hits 8732 8737 +5
Misses 177 177
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Arya Nair <aryaajitnair@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have added some inline remarks.
Additionally, I would like to request some changes/simplifications of the tests:
-
The tests should go into
test_xmp.py
. While the functionality is related to PDF/A, it is just another XMP feature. -
It should be sufficient to have exactly two tests:
- One with
sample-files/021-pdfa/crazyones-pdfa.pdf
which has these values. - One with
sample-files/020-xmp/output_with_metadata_pymupdf.pdf
which does not have these values.
The good thing about these files is that they are already cloned with a proper local development copy of the repository and do not require further downloads (and do not rely on other tests already having downloaded them).
I suggest to have a look at the other tests utilizing
SAMPLE_ROOT
as well. - One with
## What's new ### New Features (ENH) - Add PDF/A XMP metadata support (#3314) by @Arya-A-Nair ### Robustness (ROB) - Deal with annotations not being lists on merge (#3321) by @stefan6419846 - Handle NullObject for cmap encoding Differences entry (#3317) by @stefan6419846 ### Developer Experience (DEV) - Update ruff to 0.12.0 (#3316) by @stefan6419846 [Full Changelog](5.6.0...5.6.1)
Closes #3313