-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DOC: Add comments to page module #3319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
An operation takes an operator and parameters (operands) and evaluates them, thus I think that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3319 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 53 53
Lines 9046 9046
Branches 1675 1675
=======================================
Hits 8749 8749
Misses 177 177
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Let's just add comments instead
2ae4f44
to
1978c23
Compare
@stefan6419846 I undid the name change + the tiny refactoring as it increased the cyclomatic complexity and thus made the test fail -.- Now it's a comment-only PR 😄 |
Slightly related to #3010, where the goal is to refactor this rather complex method as well to increase readability and modularization. |
Could you please unify the casing of the comments to always start with an uppercase letter? |
Done 👍 |
Just some comments + a tiny refactoring. Both hopefully make the code a little bit easier to read :-)
Oh, and
process_operation
should very likely rather be calledprocess_operator
(I can undo that if you think the previous name fits better :-) )