fix: Flag assert.equal in module hooks

[arensman]

• Updated no-assert-equal rule to also catch assert.equal in module hooks
• Moved isInModule into utils (was duplicated around a few places)
• Added before and after to recognized module hook properties
• Added test case

Fixes #531

[bmish]

Just to confirm, it looks like this will be a breaking change, right? I see isModuleHookPropertyKey is used in 4 rules. Can you add a test to each of those rules if it affects them.

[arensman]

Just to confirm, it looks like this will be a breaking change, right? I see isModuleHookPropertyKey is used in 4 rules. Can you add a test to each of those rules if it affects them.

Yes, that's correct. It fits the category "Minor release > A bug fix in a rule that results in ESLint reporting more errors."
That change improves the rules to detect the before and after hooks. According to QUnit documentation, they have been added with 2.0 and have the same API as beforeEach and afterEach. That's why I'm positive this change is intended.

I've added tests for the other four rules. The tests in no-arrow-tests, no-qunit-start-in-tests, and resolve-async fail without this change. The test in no-setup-teardown passes with and without.