-
Notifications
You must be signed in to change notification settings - Fork 120
[MAIN-2976] new relic support #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comment about docs & the newrelic URL.
|
||
For more details on New Relic's API and authentication methods, refer to [New Relic API documentation](https://docs.newrelic.com/docs/apis). | ||
|
||
</details> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved to a page on robusta docs where we gathered all the toolset documentation: https://docs.robusta.dev/master/configuration/holmesgpt/builtin_toolsets.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example PR: robusta-dev/robusta#1727
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created the PR hoping to get this merged soon :)
robusta-dev/robusta#1832
""" | ||
} | ||
|
||
url = "https://api.newrelic.com/graphql" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be overridable for people having on premise newrelic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New Relic is cloud-only.
source
super().__init__( | ||
name="newrelic", | ||
description="Toolset for interacting with New Relic to fetch logs and traces", | ||
docs_url="https://docs.newrelic.com/docs/apis/nerdgraph-api/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment to the above regarding docs, URL should be similar to https://docs.robusta.dev/master/configuration/holmesgpt/toolsets/newrelic.html
I have just created the docs PR for robusta, hoping to get this merged soon 🙏🏻 |
Hi @marin-h, we haven't been able to test this as extensively as we'd like yet. Have you been using this branch? If so, would love to talk and your experience so far could help us accelerate this. |
Warning Rate limit exceeded@moshemorad has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 29 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Uh oh!
There was an error while loading. Please reload this page.