Fix: Resolve HIR display length issues and improve adjustment tooltips #20031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyfah
changed the title
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Jun 19, 2025
Comment on lines
+208
to
+210
| coercion.chars().next().unwrap().to_uppercase().collect::<String>() | ||
| + &coercion[1..], | ||
| detailed_tooltip |
There was a problem hiding this comment.
let's just manually uppercase the string literal instead of doing this
Veykril
reviewed
Jun 19, 2025
| @@ -156,6 +156,47 @@ pub(super) fn hints( | |||
| None | |||
| } | |||
|
|
|||
| fn format_function_hint(func: &ast::Fn, max_length: usize) -> Option<String> { | |||
There was a problem hiding this comment.
Imo we should do this as described in my comment in #19207 (comment) instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_function_hintfunction that includes function parameters forclosing_bracesand respects maximum length constraints by truncating parameter lists when needed