Skip to content

unnecessary_debug_formatting respect MSRV #15001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

donkomura
Copy link
Contributor

@donkomura donkomura commented Jun 6, 2025

Fixes #14977

unnecessary_debug_formatting suggested display() regardless of MSRV. This adds MSRV check for OsStr and Path.

changelog: [unnecessary_debug_formatting] respects MSRV

@donkomura donkomura marked this pull request as ready for review June 6, 2025 17:02
@rustbot
Copy link
Collaborator

rustbot commented Jun 6, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 6, 2025
@lopopolo
Copy link

hey folks, can we get this merged?

@Jarcho
Copy link
Contributor

Jarcho commented Jun 19, 2025

The lint was working correctly in the first place. Path::display has been stable since 1.0.

Can you keep just the test on OsStr?

`unnecessary_debug_formatting` suggested display() regardless of
MSRV. This adds MSRV check for OsStr.

changelog: [`unnecessary_debug_formatting`]: respects MSRV
@donkomura donkomura force-pushed the fix-unnecessary-debug-formatting-msrv branch from b2d176f to 424bdc9 Compare June 19, 2025 14:19
@donkomura
Copy link
Contributor Author

Thank you for the information. I removed the test on Path::display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnecessary_debug_formatting should respect MSRV
4 participants