Skip to content

Move metadata object generation for dylibs to the linker code #141769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented May 30, 2025

This deduplicates some code between codegen backends and may in the future allow adding extra metadata that is only known at link time.

Prerequisite of #96708.

@rustbot
Copy link
Collaborator

rustbot commented May 30, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 30, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@jieyouxu
Copy link
Member

r? codegen

@rustbot rustbot assigned workingjubilee and unassigned jieyouxu May 30, 2025
@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the codegen_metadata_module_rework branch 2 times, most recently from 74e2b70 to d3167a4 Compare May 30, 2025 15:06
@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the codegen_metadata_module_rework branch from d3167a4 to 29c3ecb Compare May 30, 2025 18:40
@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the codegen_metadata_module_rework branch from 29c3ecb to ab75435 Compare May 30, 2025 18:54
bjorn3 added 2 commits June 3, 2025 10:04
And move passing it to the linker to the driver code.
This deduplicates some code between codegen backends and may in the
future allow adding extra metadata that is only known at link time.
@bjorn3 bjorn3 force-pushed the codegen_metadata_module_rework branch from ab75435 to 0bd7aa1 Compare June 3, 2025 10:04
@workingjubilee
Copy link
Member

hmm, I feel like I don't know enough about rmeta encoding yet. the PR looks okay but

r? @saethlin

@rustbot rustbot assigned saethlin and unassigned workingjubilee Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants