Merge Cfg::render_long_html and Cfg::render_long_plain methods common code
#141770
+23
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…common code * Fix invalid whitespace handling
rustbot
added
S-waiting-on-review
GuillaumeGomez
commented
May 30, 2025
| let on = if self.omit_preposition() { | ||
| "" | ||
| " " |
There was a problem hiding this comment.
I changed this a bit because the generated whitespace characters were invalid in render_long_plain with the previous code (two whitespace characters after Available for this case).
GuillaumeGomez
force-pushed
the
cfg-false-mod-rendering
branch
from
4655783 to
358d5ea
Compare
GuillaumeGomez
commented
May 30, 2025
| // a cfg(true) will simply be ommited, as it is the same as no cfg. | ||
| //@ !has 'foo/fn.bar.html' '//div[@class="stab portability"]' '' | ||
| // a cfg(true) will simply be omited, as it is the same as no cfg. | ||
| //@ count 'foo/fn.bar.html' '//*[@class="stab portability"]' 0 |
There was a problem hiding this comment.
We should maybe restrain usage of !has as it's so easily outdated...
camelid
reviewed
Jun 3, 2025
* Fix typo * Remove usage of `!has`
GuillaumeGomez
force-pushed
the
cfg-false-mod-rendering
branch
from
358d5ea to
fca28ab
Compare
|
Fixed typo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #141747.
Thanks @camelid for spotting it!
r? @camelid