-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Merge Cfg::render_long_html
and Cfg::render_long_plain
methods common code
#141770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Merge Cfg::render_long_html
and Cfg::render_long_plain
methods common code
#141770
Conversation
…common code * Fix invalid whitespace handling
let on = if self.omit_preposition() { | ||
"" | ||
" " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this a bit because the generated whitespace characters were invalid in render_long_plain
with the previous code (two whitespace characters after Available
for this case).
4655783
to
358d5ea
Compare
// a cfg(true) will simply be ommited, as it is the same as no cfg. | ||
//@ !has 'foo/fn.bar.html' '//div[@class="stab portability"]' '' | ||
// a cfg(true) will simply be omited, as it is the same as no cfg. | ||
//@ count 'foo/fn.bar.html' '//*[@class="stab portability"]' 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should maybe restrain usage of !has
as it's so easily outdated...
* Fix typo * Remove usage of `!has`
358d5ea
to
fca28ab
Compare
Fixed typo. |
Follow-up of #141747.
Thanks @camelid for spotting it!
r? @camelid