-
Notifications
You must be signed in to change notification settings - Fork 13.4k
bootstrap: build std sans leaf frame pointers #141800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
bootstrap: build std sans leaf frame pointers #141800
Conversation
Sometimes leaf frame-pointers can impact LLVM inlining choices, and that can be a real problem for things like `mul_add`.
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…ers, r=<try> bootstrap: build std with less frame pointers Sometimes leaf frame-pointers can impact LLVM inlining choices, and that can be a real problem for things like `mul_add`. r? `@ghost`
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (53f6b1b): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary -0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -0.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.3%, secondary -0.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 778.921s -> 776.952s (-0.25%) |
Performance is almost completely invisible on a large, noisy program like rustc. But the improvements are more notable in binary size where they are modest but consistent. Not sure how to interpret the wall-time regressions in large-workspace, though. |
Get a new commit hash and try again. It's probably instability. |
Oh. Most of the large-workspace significance thresholds are still the default 0.20%. The significance estimations just aren't calibrated yet. |
I'm gonna assume that means I shouldn't worry too much about it. r? compiler |
Yeah, there's just no information to be gleaned from that benchmark. Yet. I don't know what the right reviewer group is for "how we build the precompiled sysroot" but I've been involved in this discussion a fair bit and support this change. r? saethlin |
Sometimes leaf frame-pointers can impact LLVM inlining choices, and that can be a real problem for things like
mul_add
.