-
Notifications
You must be signed in to change notification settings - Fork 13.5k
compiler-builtins: Clean up features #142659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
89b4e61
to
802792b
Compare
library/Cargo.lock
Outdated
dependencies = [ | ||
"cc", | ||
"rustc-std-workspace-core", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we now also pulling in compiler-builtins from crates.io?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea, it did this with the efi upgrade and I've been trying to figure out why. Cargo says this is a dependency of sgx, but I don't know why it isn't using the patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgx enables compiler-builtins/rustc-dep-of-std, so I guess this may be Cargo trying to resolve a now-removed feature. I'll see if they can do a release soon, or just keep the feature.
This comment has been minimized.
This comment has been minimized.
Remove the `compiler-builtins` from default because it prevents testing via the default `cargo test` command. It made more sense as a default when `compiler-builtins` was a dependency that some crates added via crates.io, but is no longer needed The `rustc-dep-of-std` feature is also removed since it doesn't do anything notable.
802792b
to
5a5d4b8
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
Remove the
compiler-builtins
from default because it prevents testing via the defaultcargo test
command. It made more sense as a default whencompiler-builtins
was a dependency that some crates added via crates.io, but is no longer neededThe
rustc-dep-of-std
feature is also removed since it doesn't do anything notable.r? @ghost