Editorial: mark the conversion operation in NumericToRawBytes as infallible #3603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
added
editorial change
completion records
bakkot
approved these changes
May 15, 2025
|
The conversion operations only throw in type coercions which aren't applicable here, so they indeed cannot throw. |
linusg
approved these changes
Jun 26, 2025
michaelficarra
added
the
ready to merge
ljharb
changed the title
ljharb
force-pushed
the
NumericToRawBytes-conversion-completion
branch
from
4f257e7 to
17b5581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't actually checked yet that there's no path that can throw here. But each of these AOs that are indirectly referenced through the table return completion records (which are sometimes abrupt!). So we better hope that they can't be made to throw.