Add makefile flag to create debug build #5009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
abe-winter
approved these changes
May 23, 2025
| @@ -9,7 +9,12 @@ PATH_WITH_TOOLS="`pwd`/$(TOOL_BIN):`pwd`/node_modules/.bin:${PATH}" | |||
| GIT_REVISION = $(shell git rev-parse HEAD | tr -d '\n') | |||
| TAG_VERSION?=$(shell ./etc/dev-version.sh | sed 's/^v//') | |||
| DATE_COMPILED?=$(shell date +'%Y-%m-%d') | |||
| COMMON_LDFLAGS = -s -w -X 'go.viam.com/rdk/config.Version=${TAG_VERSION}' -X 'go.viam.com/rdk/config.GitRevision=${GIT_REVISION}' -X 'go.viam.com/rdk/config.DateCompiled=${DATE_COMPILED}' | |||
| COMMON_LDFLAGS = -X 'go.viam.com/rdk/config.Version=${TAG_VERSION}' -X 'go.viam.com/rdk/config.GitRevision=${GIT_REVISION}' -X 'go.viam.com/rdk/config.DateCompiled=${DATE_COMPILED}' | |||
| ifdef BUILD_DEBUG | |||
There was a problem hiding this comment.
BUILD_DEBUG=0 puts this in the first case, not the second, but shrug, I think fine as-is and not worth changing / retesting
Makefile
Outdated
|
|
||
| windows: | ||
| mkdir -p bin/windows | ||
| GOOS=windows go build -tags no_cgo -ldflags="-extldflags=-static $(COMMON_LDFLAGS)" -o bin/windows/viam-server-$(shell go env GOARCH).exe ./web/cmd/server | ||
| GOOS=windows go build -tags no_cgo -$(GCFLAGS) ldflags="-extldflags=-static $(COMMON_LDFLAGS)" -o bin/windows/viam-server-$(shell go env GOARCH).exe ./web/cmd/server |
viambot
added
safe to test
As far as I can tell it's not. Nothing in the workflow definitions sets it and the workflows run on Github's provided |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a recent incident I had to create a build of the server I could usefully debug with delve. This PR just adds a flag to the makefile to make creating such a build easier in the future.
GCFLAGS:
LDFLAGS: