Update gotestsum and use github actions formatting when appropriate #5013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
jmatth
force-pushed
the
pretty-test-output
branch
from
d710b71 to
113e78c
Compare
viambot
added
safe to test
jmatth
force-pushed
the
pretty-test-output
branch
from
113e78c to
503c4cd
Compare
viambot
added
safe to test
jmatth
force-pushed
the
pretty-test-output
branch
from
ce2a8f7 to
503c4cd
Compare
viambot
added
safe to test
dgottlieb
reviewed
Jun 2, 2025
| @@ -18,8 +18,13 @@ if [[ "$1" == "race" ]]; then | |||
| LOGFILE="--jsonfile json.log" | |||
| fi | |||
|
|
|||
| FORMAT='standard-verbose' | |||
| if test -n "$GITHUB_RUN_ID"; then | |||
| FORMAT='github-actions' | |||
There was a problem hiding this comment.
I'm guessing this adds the "start/stop" github directives that group up output in tests? Such that a user can fold/unfold? And I believe the directives assume all of a tests' output is contiguous?
I assume parallel tests are still run in parallel. Does gotestsum buffer in memory all of the parallel test output?
When looking at the json.log file output, are we still able to (roughly) see which tests interleaved?
Nothing I'm raising is a blocker, just curious to know the exact behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.