add a config parameter to motion/builtin that sets a default number of threads to use #5015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
raybjork
commented
May 28, 2025
| return []string{framesystem.InternalServiceName.String()}, nil, nil | ||
| } | ||
|
|
||
| type builtIn struct { |
There was a problem hiding this comment.
moving this code to a place that is more consistent with where it is in the rest of rdk/modules
viambot
added
safe to test
randhid
reviewed
May 28, 2025
| components map[resource.Name]resource.Resource | ||
| logger logging.Logger | ||
| state *state.State | ||
| configuredDefaultExtras map[string]any |
randhid
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be useful to users who want to configure this parameter across every call they make to the motion service