RSDK-9648: Add viam CLI command to grab all captured FTDC data #5019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
stuqdog
requested changes
May 30, 2025
There was a problem hiding this comment.
A couple small things but generally looks good to me. I suspect @benjirewis (or someone from netcode) should be included as a reviewer though, since he opened the initial ticket and probably has more context for the need here than team SDK does.
viambot
added
safe to test
viambot
added
safe to test
stuqdog
approved these changes
Jun 2, 2025
benjirewis
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what the title says. Internally the new command is reusing the file copy code with presets for the path and flags.