DATA 4228: Update SDKs and CLI #5044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
gloriacai01
reviewed
Jun 10, 2025
app/data_client.go
Outdated
| @@ -1364,18 +1378,24 @@ func (d *DataClient) CreateDataPipeline( | |||
|
|
|||
| // UpdateDataPipeline updates a data pipeline configuration by its ID. | |||
| func (d *DataClient) UpdateDataPipeline( | |||
| ctx context.Context, id, name string, query []map[string]interface{}, schedule string, | |||
| ctx context.Context, id, name string, query []map[string]interface{}, schedule string, opts *CreateDataPipelineOptions, | |||
There was a problem hiding this comment.
we shouldn't wrap this in the opts struct bc this isn't optional for Update
cli/app.go
Outdated
| @@ -1654,6 +1655,10 @@ var app = &cli.App{ | |||
| Name: datapipelineFlagMQLFile, | |||
| Usage: "path to JSON file containing MQL query for the new data pipeline", | |||
| }, | |||
| &cli.StringFlag{ | |||
| Name: datapipelineFlagDataSourceType, | |||
| Usage: "data source type for the new data pipeline. Allowed values: [standard, hotstorage]", | |||
There was a problem hiding this comment.
[super nit] to follow the rest of the cli, lets use formatAcceptedValues function when outputting the allowed values
viambot
added
safe to test
viambot
removed
the
safe to test
viambot
added
the
safe to test
viambot
added
safe to test
cli/datapipelines.go
Outdated
|
|
||
| func dataSourceTypeToProto(dataSourceType string) (pb.TabularDataSourceType, error) { | ||
| switch dataSourceType { | ||
| case "standard": |
There was a problem hiding this comment.
[nit] lets move this to be vars instead of defining them here and reuse them
cli/app.go
Outdated
| @@ -1654,6 +1655,10 @@ var app = &cli.App{ | |||
| Name: datapipelineFlagMQLFile, | |||
| Usage: "path to JSON file containing MQL query for the new data pipeline", | |||
| }, | |||
| &cli.StringFlag{ | |||
| Name: datapipelineFlagDataSourceType, | |||
| Usage: "data source type for the new data pipeline. Allowed values: [standard, hotstorage]", | |||
viambot
added
safe to test
app/data_client.go
Outdated
| ) error { | ||
| mqlBinary, err := queryBSONToBinary(query) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if dataSourceType != TabularDataSourceTypeStandard && dataSourceType != TabularDataSourceTypeHotStorage { |
There was a problem hiding this comment.
Lets remove this check. We usually want the SDK to be as light weight as possible and let app handle a check like this. This check already happens there anyway so we can just remove.
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated golang sdk to account for data source type
Commands modified: GET, LIST, UPDATE, CREATE
Changes include:
note: currently in the cli, dataSourceType is optional in the sense that if you only want to modify other fields, when the update request goes through the original dataSourceType doesn't change. If this doesn't match the spec I can change it!