RSDK-10642 - support tcp-flag for module invocation #5056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested review from
abe-winter,
a team,
njooma and
gabegottlob
and removed request for
a team
viambot
added
the
safe to test
abe-winter
reviewed
Jun 16, 2025
| return err | ||
| } | ||
|
|
||
| if err := svc.initStreamServerForModule(ctx); err != nil { | ||
| if err := svc.initStreamServerForModule(ctx, server); err != nil { |
There was a problem hiding this comment.
I remember being worried about making changes to this section because I wasn't sure how to test these changes; I'll do a reread, then maybe ping a domain expert on streaming
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cribbed quite a bit from @abe-winter's POC. Blocked by api and app PRs.