RSDK-10833 Added slow shutdown logs and TestSlowShutdownTicker test #5057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
benjirewis
reviewed
Jun 16, 2025
Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com>
viambot
added
safe to test
Co-authored-by: Benjamin Rewis <32186188+benjirewis@users.noreply.github.com>
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlowStartupLoggeris now renamed toSlowLogger, and is used to measure shutdown time as well. In particular, it is added tocloseModuleandcloseResource, since these are the most important and used pieces by the clients.To check this functionality,
TestSlowShutdownTickertest was created to capture the logs that are output when resources/modules are taking a while to cleanly shutdown.