add StoppableWorkers to webcam.go #5059
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
penguinland
reviewed
Jun 16, 2025
There was a problem hiding this comment.
This is looking pretty good! I'm gonna add @nicksanford as another reviewer; he should have final approval.
Nick, this is a preliminary PR on the way to improving the latency when asking for frames from the webcam component. The plan after this is to add a buffer of recent images, and a second goroutine in the StoppableWorkers to put new images into the buffer.
For this PR, take inspiration from https://github.com/viamrobotics/rdk/pull/3941/files?diff=unified&w=1 or https://github.com/viamrobotics/rdk/pull/3939/files
penguinland
changed the title
viambot
added
safe to test
penguinland
reviewed
Jun 17, 2025
There was a problem hiding this comment.
LGTM, but I still defer to @nicksanford for final approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main changes are in the Monitor() function, webcam seems to work as expected after these changes.