module template: no need to modify meta.json when building on Windows #5063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in viam-modules/mlmodel-tflite#35, #4969, and on Slack, Windows is smart enough to know that if you try executing
foo
and the only file present isfoo.exe
, that's the one to use. So, no need to rewrite meta.json to add the.exe
suffix on Windows.This also makes the code less surprising: if I modify meta.json myself and then build without committing, I don't expect that to discard my changes! 😳
I'm tagging Julie on this PR, but that might be wrong. Julie, feel free to reassign if you don't want to review.