Skip to content

module template: no need to modify meta.json when building on Windows #5063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

penguinland
Copy link
Member

Per discussion in viam-modules/mlmodel-tflite#35, #4969, and on Slack, Windows is smart enough to know that if you try executing foo and the only file present is foo.exe, that's the one to use. So, no need to rewrite meta.json to add the .exe suffix on Windows.

This also makes the code less surprising: if I modify meta.json myself and then build without committing, I don't expect that to discard my changes! 😳

I'm tagging Julie on this PR, but that might be wrong. Julie, feel free to reassign if you don't want to review.

@penguinland penguinland requested a review from jckras June 18, 2025 15:50
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jun 18, 2025
@penguinland
Copy link
Member Author

(I noticed this yesterday when debugging something unrelated with @AGanguly13)

@jckras
Copy link
Member

jckras commented Jun 18, 2025

hey @penguinland, I can take a look though I haven't looked at this stuff since my rotation on SDK. Maybe someone on SDK would be a better fit? I tagged @purplenicole730 because I think she looked at this stuff last I remember

@jckras jckras requested a review from purplenicole730 June 18, 2025 16:54
Copy link
Member

@jckras jckras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the context I got from looking at the other PR you tagged this lgtm

Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also no longer on the SDK team, so I don't know if anything has changed. You should ask Naveed or Ethan for module generator stuff from now on. Based on the description given, it looks good.

@penguinland penguinland merged commit ffaca3b into viamrobotics:main Jun 18, 2025
18 checks passed
@penguinland penguinland deleted the no_windows_meta branch June 18, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants