std (posix): lower getpid and getppid into std.posix
#24027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
reviewed
May 29, 2025
alexrp
reviewed
May 29, 2025
alexrp
reviewed
May 29, 2025
alexrp
reviewed
May 29, 2025
alexrp
reviewed
May 30, 2025
| if (native_os == .wasi) return error.SkipZigTest; | ||
| if (native_os == .windows) return error.SkipZigTest; | ||
| if (native_os == .plan9 and !builtin.link_libc) return error.SkipZigTest; // No `getppid()`. | ||
| if ((builtin.cpu.arch == .riscv32 or builtin.cpu.arch.isLoongArch()) and builtin.os.tag == .linux and !builtin.link_libc) return error.SkipZigTest; // No `getppid()`. |
There was a problem hiding this comment.
No getppid? That seems unlikely?
There was a problem hiding this comment.
riscv does return an error mentioning the missing syscall without linking libc (or at least a mapping to it). I'm not all too familiar with riscv or the syscall interfaces in Zig yet, though
There was a problem hiding this comment.
If you look at lib/std/os/linux/syscalls.zig, RISC-V definitely has the syscall number. (And this file is generated from kernel sources.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply puts
getpid()andgetppid()intostd.posixby making use ofposix.systemif available. Removes a tiny bit of boilerplate when making cross-Darwin-Linux platform stuff by not referencingstd.corstd.os.linuxdirectly.Also adds a proper test for
getppid(). Kind of depends onfork()andwaitpid()but I'm not sure what the policy of inter-dependent tests are.