-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
libc: replace musl's and MinGW's trigonometric functions with compiler_rt's #24034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libc: replace musl's and MinGW's trigonometric functions with compiler_rt's #24034
Conversation
- sin - sinf - cos - cosf - sincos - sincosf - tan - tanf
It seems like we also have
in |
When deleting musl files, I was able to run the deletion after confirming with zig-libc-test that the function behavior did not change. |
I don't think so. musl tends to be pretty good about math functions, so until we have evidence to the contrary, let's assume that it's a good baseline for math functions for all static libcs. |
- sinf - cosf - sincos - sincosf - tanf
Thanks, I deleted the MinGW files with relief. (71ff383) |
Nice, thank you |
Sorry @alexrp, I didn't notice you had assigned yourself or I would have left it in your hands. |
No worries, I'm not calling dibs or anything. 🙂 |
Part of #2879.
According to the instruction, this PR removes some musl files, including the following functions:
I confirmed that running
zig build test-modules
and zig-libc-test raised no errors during the trigonometric function tests.zig-libc-test revealed some discrepancies between the results of long double trigonometric functions in compiler_rt and musl. Therefore, this PR is restricted to float and double functions.