-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
compiler: fix races in link queue #24171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I messed up atomic orderings on this variable because they changed in a local refactor at some point. We need to always release on the store and acquire on the loads so that a linker thread observing `.ready` sees the stored MIR.
GitHub in its infinite wisdom seems to have incinerated the corresponding logs, but: there's a very remote possibility that this caused the EDIT: nope, that was happening because of a really obvious bug which I somehow missed. Thanks @jacobly0 for picking up on it -- fix pushed to this PR. |
I did some sleuthing and unincinerated the log:
|
Did you know that allocators reuse addresses? If not, then don't feel bad, because apparently I don't either! This dumb mistake was probably responsible for the CI failures on `master` yesterday.
I messed up atomic orderings on this variable because they changed in a local refactor at some point. We need to always release on the store and acquire on the loads so that a linker thread observing
.ready
sees the stored MIR.