Step-style support for compile_commands.json generation #24178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to #22012 and #18391, this PR introduces a new
b.addCompileCommands
along with the corresponding Step implementation. I believe this approach is more flexible than using-fcompdb / -fno-compdb
.The only issue is that I made this thing look ugly, and I can't think of a better way to do it.
I've simply wrapped it into a Step — the original implementation comes from the two PRs I mentioned earlier.