feat(chart): refactor helm chart #3645
Conversation
norman-zon
force-pushed
the
helmchart-refactor
branch
13 times, most recently
from
6bc2d54 to
3aee4aa
Compare
norman-zon
requested review from
mumoshu,
toast-gear,
rentziass and
a team
as code owners
norman-zon
force-pushed
the
helmchart-refactor
branch
from
3aee4aa to
161d2f3
Compare
To avoid having to completely define template.spec, in case the user
wanted to make significant changes to the runner pod, new values
extra{Args,Env,VolumeMounts...} are introduced.
This also makes the helm chart follow a more canonical layout than
before
norman-zon
force-pushed
the
helmchart-refactor
branch
from
161d2f3 to
2ea1163
Compare
|
+1 on this PR, and waiting it to be merged and released. |
|
@mumoshu , @rentziass , @toast-gear can we get eyes from any of code owners please? |
|
This feature is helpful. Can we get this reviewed and merged please? |
|
Also a support for imagePullSecrets in the helm chart would be helpful. Regarding #2808 a registry mirror would be a solution to possible rate limits pulling the docker-in-docker image when using containerType 'dind'. Passing a Secret to the chart in order to make it possible to pull dind from a private registry would solve this as well. Are there any updates on this? |
Make it possible to set ImagePullSecret for the runner Pod
|
@norman-zon thanks for the quick reply. I have a small addition that would be really nice to have as well. What i can see from now is that every runner pod pulls the container images again from dockerhub. Like using imagePullPolicy 'always'. Making the pullPolicy configurable would also decrease the number of pulls and could fasten up the pod creation thus achieving a faster built time for each github workflow executed on a self-hosted runnner. |
|
@cpotter302 pulling I don't know if setting |
|
Any updates on this getting merged? We need to inject daemon.json into docker dind container to enable IPv6 support on an IPv6-only cluster, and currently not even using the spec works, not even resources gets added to |
|
any updates on this? 🙏 related to #3709 (comment) cc: @mumoshu , @rentziass , @toast-gear, @Link- |
|
Can we please get this merged so #3709 can be supported 🙏 |
|
Any updates here? |
The reactions and follow up discussion in #3216 seemed to signal users are interested in a design for the helm chart, where pod configuration is done using
extra...values, instead of thetemplate.specapproach.I understand the design decision for the current implementation, but wanted to provide an alternative.