fix: always set testrun outcome to flaky_failure in process flakes #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were only setting this outcome to flaky failure if we were creating a new flake, but any failure on the main branch should be considered a flaky failure (by our heuristic) so to be correct we should be setting the outcome to flaky no matter if it 's for an existing flake or a new flake
a scenario where this would have been broken is if we had 2 uploads in quick succession and the flake weren't created by the first upload by the time we were processing the tests in the second, in this case we'd be missing a flaky test outcome on the second testrun