Skip to content

[search-input-nav] Fix search icon overlap #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShirshenduR
Copy link

Notes for Reviewers

This PR fixes #622

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>
Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 2fb351e
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/68668241ab13ab0008fec3b0
😎 Deploy Preview https://deploy-preview-627--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ShirshenduR
Copy link
Author

ShirshenduR commented Jul 3, 2025

@Ayushmore1214 @vishalvivekm @vr-varad Please review

@@ -33,6 +33,12 @@
{{ $offlineSearchLink := $offlineSearchIndex.RelPermalink -}}

<div class="td-search td-search--offline">
<style>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a .styles file for this? @ShirshenduR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about neither? 😉

Please follow the establish practice of extending styling in this repo's respective SASS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Bar content Overlapping
3 participants