Skip to content

Added the animated-card component #6570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

oseniabdulhaleem
Copy link

Description

This PR adds the Animation Card Component #6521

Notes for Reviewers

  • Added the animation card component as provided in the html file

Signed commits

  • Yes, I signed my commits.

A video of how it renders

https://drive.google.com/file/d/1ihandK3cI0CSe6Gp3y6gh3bp5wTu0JH-/view?usp=sharing

@l5io
Copy link
Contributor

l5io commented Jun 22, 2025

🚀 Preview for commit af797bc at: https://68581aa39e5549db716d36a9--layer5.netlify.app

@vishalvivekm
Copy link

@oseniabdulhaleem
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

Signed-off-by: Oseni Abdulhaleem <oseniabdulhaleem@gmail.com>
@github-actions github-actions bot added the area/blog New posts or new blog functionality label Jun 23, 2025
oseniabdulhaleem and others added 2 commits June 23, 2025 13:02
Signed-off-by: Oseni Abdulhaleem <oseniabdulhaleem@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jun 23, 2025

🚀 Preview for commit 6d74525 at: https://6859539eafb3acd94911ea9e--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jun 23, 2025

🚀 Preview for commit f23d3d2 at: https://68595a17579051c7f5a2a327--layer5.netlify.app

Copy link

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs improvements, as discussed in sites call.

  1. theme friendliness
  2. responsiveness
  3. can be incorporated on cards on homepage?

@oseniabdulhaleem
Copy link
Author

oseniabdulhaleem commented Jun 30, 2025

@vishalvivekm I just made an update for theme friendliness

@l5io
Copy link
Contributor

l5io commented Jun 30, 2025

🚀 Preview for commit 8424297 at: https://686224c18482fc4e1631497b--layer5.netlify.app

@LibenHailu
Copy link
Contributor

Hi @oseniabdulhaleem , Thank you for your contribution These are the high-level issues I came across,
image
The animation wave is not there on light mode, please remove everything that says Test, if the change is approved, it will be merged so make sure your code is ready to be merged when raising a PR.
image
The animation is covering blogs, Please test it thoroughly. The DCO check is also failing.

@oseniabdulhaleem
Copy link
Author

oseniabdulhaleem commented Jun 30, 2025

@LibenHailu İ will look into those updates

Thanks for the feedback

@vr-varad
Copy link
Contributor

@oseniabdulhaleem
Thank you for your contribution!
Let's discuss this during the website call today at 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@oseniabdulhaleem
Copy link
Author

@LibenHailu Thanks for the feedback! I should clarify - the HTML and CSS code didn't include specifications for the wavy animation in light mode, which is why I didn't implement it initially. I can certainly develop something if you'd like.

@vr-varad Unfortunately, I have a work meeting conflict at 7 AM CT today. Would it be possible to discuss this during our next website meeting instead? I can add it to the agenda and continue working on the implementation in the meantime.

@l5io
Copy link
Contributor

l5io commented Jul 1, 2025

🚀 Preview for commit 6974230 at: https://6863d3cab8966db613e2f207--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jul 1, 2025

🚀 Preview for commit 137e6b9 at: https://6863e6152de5e5324ff680a5--layer5.netlify.app

@oseniabdulhaleem
Copy link
Author

@vishalvivekm @vr-varad Any update?

@oseniabdulhaleem
Copy link
Author

@vishalvivekm @LibenHailu @vr-varad any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog New posts or new blog functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants