-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added the animated-card component #6570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🚀 Preview for commit af797bc at: https://68581aa39e5549db716d36a9--layer5.netlify.app |
@oseniabdulhaleem Add it as an agenda item to the meeting minutes, if you would :) |
Signed-off-by: Oseni Abdulhaleem <oseniabdulhaleem@gmail.com>
Signed-off-by: Oseni Abdulhaleem <oseniabdulhaleem@gmail.com>
🚀 Preview for commit 6d74525 at: https://6859539eafb3acd94911ea9e--layer5.netlify.app |
🚀 Preview for commit f23d3d2 at: https://68595a17579051c7f5a2a327--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs improvements, as discussed in sites call.
- theme friendliness
- responsiveness
- can be incorporated on cards on homepage?
@vishalvivekm I just made an update for theme friendliness |
🚀 Preview for commit 8424297 at: https://686224c18482fc4e1631497b--layer5.netlify.app |
Hi @oseniabdulhaleem , Thank you for your contribution These are the high-level issues I came across, |
@LibenHailu İ will look into those updates Thanks for the feedback |
@oseniabdulhaleem Add it as an agenda item to the meeting minutes, if you would :) |
@LibenHailu Thanks for the feedback! I should clarify - the HTML and CSS code didn't include specifications for the wavy animation in light mode, which is why I didn't implement it initially. I can certainly develop something if you'd like. @vr-varad Unfortunately, I have a work meeting conflict at 7 AM CT today. Would it be possible to discuss this during our next website meeting instead? I can add it to the agenda and continue working on the implementation in the meantime. |
🚀 Preview for commit 6974230 at: https://6863d3cab8966db613e2f207--layer5.netlify.app |
🚀 Preview for commit 137e6b9 at: https://6863e6152de5e5324ff680a5--layer5.netlify.app |
@vishalvivekm @vr-varad Any update? |
@vishalvivekm @LibenHailu @vr-varad any update? |
Description
This PR adds the Animation Card Component #6521
Notes for Reviewers
Signed commits
A video of how it renders
https://drive.google.com/file/d/1ihandK3cI0CSe6Gp3y6gh3bp5wTu0JH-/view?usp=sharing