Fix: SSRF and Stack Trace Exposure in S3 Storage Configuration #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…23#58) This commit introduces a minimal placeholder file corresponding to Issue AIxBlock-2023#58, where an authenticated user can delete another user’s account using the /api/users/{user_id} endpoint. Signed-off-by: pravinkumar-exe <52107447+pravinkumar-exe@users.noreply.github.com>
This commit adds a placeholder file as part of the bug submission process for issue AIxBlock-2023#116. The file references the exposure of internal infrastructure details to normal users via the endpoint 'https://app.aixblock.io//api/settings/installation-service/'. This is made from my forked branch to meet the required PR workflow. Looking forward to feedback. Signed-off-by: pravinkumar-exe <52107447+pravinkumar-exe@users.noreply.github.com>
This commit adds a security fix for a critical SSRF vulnerability in the S3 storage configuration endpoint (PUT /api/storages/s3-server/{id}).
The patch introduces:
Validation to allow only trusted AWS S3 endpoints.
Filtering of internal/private IP addresses via DNS resolution.
Input validation for the bucket name.
Suppressed verbose stack traces to avoid backend logic disclosure.
Signed-off-by: pravinkumar-exe <52107447+pravinkumar-exe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses a critical SSRF vulnerability in the PUT /api/storages/s3-server/{id} endpoint by:
Blocking internal/private IPs via DNS resolution.
Allowing only valid AWS S3 endpoints.
Validating the bucket name format.
Preventing verbose stack trace leaks on connection failures.
Issue: #155