Do not skip component editor if blanking component data was selected #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
…nent data was selected The user needs to enter the component data before proceeding, skipping is not an option AI fix Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refines the skip condition logic in the component_editor function to ensure that component data is required when blanking is selected.
- Updated the skip condition in ardupilot_methodic_configurator/main.py to require a valid vehicle_dir_window with configuration_template and non-empty blank_component_data.
- Modified the test in tests/test__main__.py to simulate the scenario where the skip condition is met.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ardupilot_methodic_configurator/main.py | Refines the skip condition logic to ensure the component editor is not skipped improperly. |
| tests/test__main__.py | Updates the test setup to mirror the new condition by setting vehicle_dir_window to None. |
Comments suppressed due to low confidence (1)
tests/test__main__.py:1158
- [nitpick] Consider adding additional test cases to cover scenarios where vehicle_dir_window exists but either configuration_template is missing or blank_component_data.get() returns a falsy value, to ensure complete coverage of the new skip logic.
application_state.vehicle_dir_window = None
| @@ -317,7 +317,12 @@ def component_editor(state: ApplicationState) -> None: | |||
| ) | |||
|
|
|||
| # Handle skip component editor option | |||
| if state.args.skip_component_editor: | |||
| should_skip_editor = state.args.skip_component_editor and not ( | |||
There was a problem hiding this comment.
The combined boolean condition is somewhat complex; consider refactoring it into a helper function or adding inline comments for each sub-condition to improve readability and maintainability.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user needs to enter the component data before proceeding, skipping is not an option
This pull request refines the logic in the
component_editorfunction withinardupilot_methodic_configurator/__main__.pyto ensure that the component editor is only skipped under specific conditions.Logic refinement:
state.args.skip_component_editoris true and thevehicle_dir_windowhas a validconfiguration_templateand non-emptyblank_component_data.