-
Notifications
You must be signed in to change notification settings - Fork 42
Comparing changes
Open a pull request
base repository: Automattic/VIP-Coding-Standards
base: develop
head repository: Automattic/VIP-Coding-Standards
compare: feature/use-phpcsutils-1.1.0
- 8 commits
- 8 files changed
- 1 contributor
Commits on Nov 22, 2024
-
Composer: raise the minimum supported PHPCSUtils version to 1.1.0
... to benefit from new functionality. This also automatically raises the minimum PHPCS version to `3.10.1` for PHP 8.2 DNF type support (minimum required PHPCS for PHPCSUtils since v1.0.12). Includes updating the README which was missed for the previous Composer update. Ref: https://github.com/PHPCSStandards/PHPCSUtils/releases/tag/1.1.0
Configuration menu - View commit details
-
Copy full SHA for 1094177 - Browse repository at this point
Copy the full SHA 1094177View commit details -
Security/Underscorejs: start using the PHPCSUtils
FilePath
utilityThe `FilePath::getName()` method will strip quotes from the file name, as well as normalize the slashes to forward (*nix) slashes. This allows for a minor simplication in the code and improves code readability.
Configuration menu - View commit details
-
Copy full SHA for c944d71 - Browse repository at this point
Copy the full SHA c944d71View commit details -
AlwaysReturnInFilterUnitTest: remove PHPCS version toggle
... which is no longer needed.
Configuration menu - View commit details
-
Copy full SHA for 0c3924a - Browse repository at this point
Copy the full SHA 0c3924aView commit details -
Classes/DeclarationCompatibility: remove redundant property
Remove a property which keeps track of a current "state". These type of properties are error prone and in this case not necessary anyway as the value of the property is only used in one place and could just have easily been passed as a function argument. Include minor reformatting of a few long function calls for readability.
Configuration menu - View commit details
-
Copy full SHA for 4e9860a - Browse repository at this point
Copy the full SHA 4e9860aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4410eb - Browse repository at this point
Copy the full SHA f4410ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3f3444 - Browse repository at this point
Copy the full SHA c3f3444View commit details -
Classes/DeclarationCompatibility: minor improvement to the tests
Remove a property which keeps track of a current "state". These type of properties are error prone and in this case not necessary anyway as the value of the property is only used in one place and could just have easily been passed as a function argument. Include minor reformatting of a few long function calls for readability.
Configuration menu - View commit details
-
Copy full SHA for 9d0cc8d - Browse repository at this point
Copy the full SHA 9d0cc8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0e1def - Browse repository at this point
Copy the full SHA c0e1defView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff develop...feature/use-phpcsutils-1.1.0