Skip to content

[minor_changes]Adding guidelines for Ansible ACI module developement (DCNE-80) #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

anvitha-jain
Copy link
Collaborator

@anvitha-jain anvitha-jain commented May 14, 2025

solves #278

@anvitha-jain anvitha-jain self-assigned this May 14, 2025
@anvitha-jain anvitha-jain added the documentation Improvements or additions to documentation label May 14, 2025
@github-actions github-actions bot changed the title [minor_changes]Adding guidelines for Ansible ACI module developement [minor_changes]Adding guidelines for Ansible ACI module developement (DCNE-80) Jun 4, 2025
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sanity fails

@anvitha-jain anvitha-jain requested review from samiib and akinross June 17, 2025 16:25
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also mention the black formatting and flake8 checks in a few points?

Added

samiib
samiib previously approved these changes Jun 25, 2025
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anvitha-jain anvitha-jain requested review from shrsr and akinross July 25, 2025 03:55
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this module intended to be removed?

Copy link
Collaborator

@samiib samiib Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this module is still being removed.

:-> Added back

@anvitha-jain anvitha-jain requested a review from samiib July 25, 2025 17:56
Copy link
Collaborator

@samiib samiib Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this module is still being removed.

:-> Added back

@anvitha-jain anvitha-jain requested a review from samiib July 30, 2025 18:29
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Cisco ACI development and scenario guides to this collection. (DCNE-80)
6 participants