add Nutanix support to aci_epg_to_domain (DCNE-446) #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camrossi
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
akinross
force-pushed
the
master
branch
5 times, most recently
from
18b3a08 to
ea02224
Compare
shrsr
requested changes
Jun 17, 2025
plugins/modules/aci_epg_to_domain.py
Outdated
| choices: [ enabled, disabled ] | ||
| ipam_dhcp_override: | ||
| description: | ||
| - The IP address management (IPAM) Dynamic Host Configuration Protocol (DHCP) override. |
There was a problem hiding this comment.
->
- The IP Address Management (IPAM) Dynamic Host Configuration Protocol (DHCP) override.
plugins/modules/aci_epg_to_domain.py
Outdated
| type: str | ||
| ipam_enabled: | ||
| description: | ||
| - The IP address management (IPAM) enabled state. |
There was a problem hiding this comment.
The IP Address Management (IPAM) enabled state.
plugins/modules/aci_epg_to_domain.py
Outdated
| type: bool | ||
| ipam_gateway: | ||
| description: | ||
| - The IP address management (IPAM) gateway. |
There was a problem hiding this comment.
- The IP Address Management (IPAM) gateway.
samiib
requested changes
Jun 24, 2025
plugins/modules/aci_epg_to_domain.py
Outdated
| choices: [ cos_0, cos_1, cos_2, cos_3, cos_4, cos_5, cos_6, cos_7 ] | ||
| epg_cos_preference: | ||
| description: | ||
| - The class of service (CoS) preference. |
There was a problem hiding this comment.
I don't think you need to expand on the acronyms every time its used in the descriptions. Perhaps one per module should be enough?
akinross
dismissed stale reviews from anvitha-jain, sajagana, gmicol, lhercot, and shrsr
via
5f6679d
…gCosPref, ipamDhcpOverride, ipamEnabled, ipamGateway, lagPolicyName, netflowDir, primaryEncapInner, secondaryEncapInner
… aci_domain_to_encap_pool, aci_domain_to_vlan_pool, aci_vmm_controller, aci_vmm_credential
…_vmm_enhanced_lag_policy
akinross
dismissed stale reviews from lhercot, samiib, gmicol, sajagana, anvitha-jain, and shrsr
via
8435302
akinross
requested review from
lhercot,
shrsr,
anvitha-jain,
sajagana,
samiib and
gmicol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.