Skip to content

Refactor Expander.ContentHeight and ExpanderAnimationBehavior #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Refactor Expander.ContentHeight and ExpanderAnimationBehavior #2723

wants to merge 5 commits into from

Conversation

stephenquan
Copy link
Contributor

Description of Change

  • Refactor/Rewrite Expander to expose Expander.ContentHeight
  • Created ExpanderAnimationBehavior that animates the ContentHeight

Linked Issues

Linked Discussions

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description): TODO
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: TODO

Additional information

This PR was created to solicit further suggestions from the team.
This PR is a continuation of the discussion that began in this obsolete PR #2522

@stephenquan
Copy link
Contributor Author

@VladislavAntonyuk, I have recreated this PR based on your feedback in #2522 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladislavAntonyuk VladislavAntonyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal] Expander animation
3 participants
@stephenquan @VladislavAntonyuk @TheCodeTraveler